<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6839/">http://svn.reviewboard.kde.org/r/6839/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 5th, 2011, 9:23 a.m., <b>Ian Wadham</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship it.
I have tested the patch with several KMahjongg layouts, including Hole and Crab, which have multiple tile edges showing in the hole and multiple partial overlaps. Everything works fine. Clicking on a shadow selects the tile that is in shadow, provided it is not overlapped. Clicking on a tile edge selects that tile, provided it is on top and free. And I agree with Christian, that how the patch works is how it *should* work. No special cases or "Selection Assistance", please, even if it saves a click in a few cases. Simplicity is a virtue.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please note the feature freeze in trunk. Or does this go through as a bugfix?</pre>
<br />
<p>- Frederik</p>
<br />
<p>On December 3rd, 2011, 1:34 p.m., Christian Krippendorf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Christian Krippendorf.</div>
<p style="color: grey;"><i>Updated Dec. 3, 2011, 1:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug List Link: https://bugs.kde.org/show_bug.cgi?id=286927</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdegames/kmahjongg/boardwidget.h <span style="color: grey">(1267104)</span></li>
<li>trunk/KDE/kdegames/kmahjongg/boardwidget.cpp <span style="color: grey">(1267104)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6839/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>