<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6839/">http://svn.reviewboard.kde.org/r/6839/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 4th, 2011, 3:28 a.m., <b>Ian Wadham</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The code looks good to me, but I have not tested it yet.
One picky little thing occurs to me. Do the visible vertical faces of tiles count as "shadow" or "tile"? Ideally they should count as "shadow" (i.e. you should select the *top* face of a tile). But then what should happen if there is a tile underneath and partly in shadow? Does clicking the vertical face select the lower tile (WRONG)? Does clicking the vertical face select nothing at all (irritating)? On balance and in the interests of practicality, I think clicking a vertical face should select the tile it is a part of.</pre>
</blockquote>
<p>On December 4th, 2011, 5:12 a.m., <b>Wolfgang Rohdewald</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree with Ian but with two exceptions:
- If there is no other tile below the shadow it might be nice if clicking on the shadow also selects the tile
- if a tile fully covers a lower tile and the click would select the lower tile (on its vertical face or on its shadow), it should automatically select the upper tile
that would reduce the change in behaviour to the really faulty situations</pre>
</blockquote>
<p>On December 4th, 2011, 2:35 p.m., <b>Christian Krippendorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, but i don't know what u mean with "vertical faces". The side of the stone in 3D reflection? As this is part of the tile and not the shadow. If u click on such a side, that is not overlaid by another tile. The tile will get selected the side is related to. So it is like u said in the last sentence. (on my tests with the code here. :) )
@Wolfgang
Please NO!!!! A shadow is a shadow, that's all. Shadow should be like there is nothing. If clicking on a shadow selects the tile below (if there is one) and on the other side select the tile the shadow it is related to (if there is no tile below), people out there will think this could be a bug. The selection should work consistent, please.
@All
Feel free to test the code :)
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">imagine a stack of 3 stone directly over each other. By your logic, clicking on the vertical face (yes, the side of the stone in 3D) of the middle stone would select the lowest stone because the click is actually within the face of the lowest stone and not within the face of any other stone. But selecting a lower stone is never possible so in this case no stone would be selected at all. I do not think it would be confusing to select the upper stone in this special case. Ians logic would try to select the middle stone which again is not possible.
shadows: I accept your argument, fine with me. OTOH I would not think of this as a bug but a friendly help by the computer (you clicked on nothing - but wait - your click covers a shadow, so you probably meant that one)
</pre>
<br />
<p>- Wolfgang</p>
<br />
<p>On December 3rd, 2011, 1:34 p.m., Christian Krippendorf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Christian Krippendorf.</div>
<p style="color: grey;"><i>Updated Dec. 3, 2011, 1:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug List Link: https://bugs.kde.org/show_bug.cgi?id=286927</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdegames/kmahjongg/boardwidget.h <span style="color: grey">(1267104)</span></li>
<li>trunk/KDE/kdegames/kmahjongg/boardwidget.cpp <span style="color: grey">(1267104)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6839/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>