<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6805/">http://svn.reviewboard.kde.org/r/6805/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games and Pierre Ducroquet.</div>
<div>By Jeffrey Kelling.</div>
<p style="color: grey;"><i>Updated Sept. 18, 2011, 7:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed bug in Player::deleteStandingOrder(): iteration broke on deletion.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch implements standing orders, i.e. orders that are repeated each turn if possible. Standing orders are issued the same way as normal order, additionally the added check box has to be checked. They are also removed the same way as normal orders (in the fleet overview). The orders are executed at the end of turn if enough ships are available, if not a message is issued. If the Planet is no longer under the players control the order is deleted.
The number of ships that will be send due to standing order from a planet is displayed in that planets planet info (to its owner only).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Played the game, issued standing orders, ...</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=87882">87882</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdegames/konquest/dialogs/fleetdlg.h <span style="color: grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/dialogs/fleetdlg.cc <span style="color: grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/game.h <span style="color: grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/game.cpp <span style="color: grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/gameview.h <span style="color: grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/gameview.cc <span style="color: grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/map/mapitems.cc <span style="color: grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/planet.cc <span style="color: grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/players/player.h <span style="color: grey">(1254115)</span></li>
<li>trunk/KDE/kdegames/konquest/players/player.cpp <span style="color: grey">(1254115)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6805/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/6805/s/621/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2011/09/13/standingOrders_400x100.png" style="border: 1px black solid;" alt="Spawn Fleet" /></a>
<a href="http://svn.reviewboard.kde.org/r/6805/s/622/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2011/09/13/standingOrdersFleetOverView_400x100.png" style="border: 1px black solid;" alt="Fleet Overview" /></a>
<a href="http://svn.reviewboard.kde.org/r/6805/s/623/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2011/09/13/standingOrdersInPlanetInfo_400x100.png" style="border: 1px black solid;" alt="Ships needed for standing orders in planet info" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>