<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5399/">http://svn.reviewboard.kde.org/r/5399/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Games.</div>
<div>By Lindsay Mathieson.</div>


<p style="color: grey;"><i>Updated 2010-09-25 12:16:31.343488</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed spaces
Updated BallItem to use async pixmap loadig (setSpriteKey)
Updated KLinesRender 
  - Fully singleton with static access to exposed members rather than via &quot;self()&quot; function
  - Initiliased/Free&#39;d in KLinesMainWindow constructor and destructor rather than static initialisation</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updates klines to use KGameRenderer and KGameRenderedItem in place of QSvgRenderer and QGraphicsPixmapItem
Removes KPixmapCache usage</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Playing game
Changing themes
Resizing game
Comparison with original</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdegames/klines/animator.cpp <span style="color: grey">(1177731)</span></li>

 <li>/trunk/KDE/kdegames/klines/ballitem.h <span style="color: grey">(1177731)</span></li>

 <li>/trunk/KDE/kdegames/klines/ballitem.cpp <span style="color: grey">(1177731)</span></li>

 <li>/trunk/KDE/kdegames/klines/klines.cpp <span style="color: grey">(1177731)</span></li>

 <li>/trunk/KDE/kdegames/klines/previewitem.cpp <span style="color: grey">(1177731)</span></li>

 <li>/trunk/KDE/kdegames/klines/renderer.h <span style="color: grey">(1177731)</span></li>

 <li>/trunk/KDE/kdegames/klines/renderer.cpp <span style="color: grey">(1177731)</span></li>

 <li>/trunk/KDE/kdegames/klines/scene.cpp <span style="color: grey">(1177731)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5399/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>