<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5238/">http://svn.reviewboard.kde.org/r/5238/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I will commit this. Re the default theme problems:
"Following KMines, the patch simply passes in Settings::theme() when constructing the KGameRenderer, however kblocks.kcfg has no default value for the theme, so no theme is loaded. I believe that the proper fix for this is to add a default value to the config file, correct? Alternatively, should KGameRendererPrivate::setTheme() call KGameTheme::loadDefault() when it receives 0-length theme string instead of just bailing?"
KGameRenderer explicitly wants the *default* theme when it is constructed, to be able to fallback to the default in broken themes. If one uses a Settings class (i.e. a KConfigSkeleton), as most to all KDE games do, the proper solution thus is to obtain the default value from this Settings class. KPat demoes how to do this, and I'll now adapt this to all other games.</pre>
<br />
<p>- Stefan</p>
<br />
<p>On September 11th, 2010, 2:45 p.m., Brian Croom wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games and Stefan Majewsky.</div>
<div>By Brian Croom.</div>
<p style="color: grey;"><i>Updated 2010-09-11 14:45:36</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As KNetWalk's use of QWidget as its graphics stack was marked in red on the porting status wiki page, and because I wanted to see if I had acquired a good enough working understanding of the QGraphicsView framework to be able to accomplish it, I decided to attempt a full port of this game. I referred to the KMines source while restructuring the code, as it has various conceptually similar elements (a grid with square cells that are activated by the user during gameplay, etc.)
Doing this required some rather invasive changes to the GUI code. In addition to switching to QGraphicsView, this patch also:
- Removes the distinction between mouse and keyboard input modes. They now work together nicely, as they should.
- Adds the ability to pause the game, and hide the puzzle while it is paused.
- Cleans up code in various places and removes a number of obsolete class members that I presume to have been vestiges from before the KDE port.
My only disappointment is that switching to QGraphicsView did not get rid of the rendering artifacts that often appear when the cables are being rotated. Particularly on the cells with T-shaped cable junctions, white pixels often appear at the edge of the pixmap during the rotation animation. I would greatly appreciate any suggestions for how to avoid that happening.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have come to enjoy playing this game quite a lot, and have given it considerable testing. All the usual things seem to work well including resizing, theme changes, changing difficulty level, and pausing/resuming.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdegames/knetwalk/src/CMakeLists.txt <span style="color: grey">(1173706)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/abstractgrid.h <span style="color: grey">(1173706)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/abstractgrid.cpp <span style="color: grey">(1173706)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/cell.h <span style="color: grey">(1173706)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/cell.cpp <span style="color: grey">(1173706)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/fielditem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/fielditem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/globals.h <span style="color: grey">(1173706)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/knetwalk.kcfg <span style="color: grey">(1173706)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/knetwalkui.rc <span style="color: grey">(1173706)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/main.cpp <span style="color: grey">(1173706)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/mainwindow.h <span style="color: grey">(1173706)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/mainwindow.cpp <span style="color: grey">(1173706)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/renderer.h <span style="color: grey">(1173706)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/renderer.cpp <span style="color: grey">(1173706)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/scene.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/scene.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/view.h <span style="color: grey">(1173706)</span></li>
<li>/trunk/KDE/kdegames/knetwalk/src/view.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5238/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>