<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5192/">http://svn.reviewboard.kde.org/r/5192/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks ok to me, though can't test right now. But if you tested and it works for you, go ahead :)</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5192/diff/1/?file=34844#file34844line29" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdegames/kmines/borderitem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span><span class="n">s_elementNames</span><span class="p">.</span><span class="n">empty</span><span class="p">())</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">isEmpty() is more qt-style ;)</pre>
</div>
<br />
<p>- Dmitry</p>
<br />
<p>On August 30th, 2010, 7:34 a.m., Brian Croom wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.</div>
<div>By Brian Croom.</div>
<p style="color: grey;"><i>Updated 2010-08-30 07:34:33</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch ports KMines to use KGameRenderer.
The only complication for this one was the layered pixmaps used when displaying cells. As for KReversi, I added KGameRenderedItem instances as children of the cell item, which seems to work well. Let me know what you think of the implementation in this case.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Brief testing has revealed no regressions. Resizing and theme changes work properly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdegames/kmines/CMakeLists.txt <span style="color: grey">(1168585)</span></li>
<li>/trunk/KDE/kdegames/kmines/borderitem.h <span style="color: grey">(1168585)</span></li>
<li>/trunk/KDE/kdegames/kmines/borderitem.cpp <span style="color: grey">(1168585)</span></li>
<li>/trunk/KDE/kdegames/kmines/cellitem.h <span style="color: grey">(1168585)</span></li>
<li>/trunk/KDE/kdegames/kmines/cellitem.cpp <span style="color: grey">(1168585)</span></li>
<li>/trunk/KDE/kdegames/kmines/main.cpp <span style="color: grey">(1168585)</span></li>
<li>/trunk/KDE/kdegames/kmines/mainwindow.cpp <span style="color: grey">(1168585)</span></li>
<li>/trunk/KDE/kdegames/kmines/minefielditem.h <span style="color: grey">(1168585)</span></li>
<li>/trunk/KDE/kdegames/kmines/minefielditem.cpp <span style="color: grey">(1168585)</span></li>
<li>/trunk/KDE/kdegames/kmines/renderer.h <span style="color: grey">(1168585)</span></li>
<li>/trunk/KDE/kdegames/kmines/renderer.cpp <span style="color: grey">(1168585)</span></li>
<li>/trunk/KDE/kdegames/kmines/scene.h <span style="color: grey">(1168585)</span></li>
<li>/trunk/KDE/kdegames/kmines/scene.cpp <span style="color: grey">(1168585)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5192/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>