<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5059/">http://reviewboard.kde.org/r/5059/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">pictures/theme.desktop is missing from the patch.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5059/diff/2/?file=34117#file34117line43" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdegames/kollision/mainarea.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">struct Collision</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="o">:</span> <span class="n">m_man</span><span class="p">(</span><span class="mi">0</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="o">:</span> <span class="n">m_renderer</span><span class="p">(</span><span class="n">KStandardDirs</span><span class="o">::</span><span class="n">locate</span><span class="p">(</span><span class="s">"appdata"</span><span class="p">,</span> <span class="s">"pictures/theme.desktop"</span><span class="p">))</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn't this be just m_renderer("pictures/theme.desktop")? KGameRenderer/KGameTheme is supposed to do the KStandardDirs stuff.</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Other than that, stuff looks good, so I'll commit this patch when the mentioned points have been addressed.</pre>
<p>- Stefan</p>
<br />
<p>On August 17th, 2010, 3:20 p.m., Brian Croom wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.</div>
<div>By Brian Croom.</div>
<p style="color: grey;"><i>Updated 2010-08-17 15:20:31</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch ports Kollision to use the KGameRenderer class for rendering balls.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Everything seems to work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdegames/kollision/CMakeLists.txt <span style="color: grey">(1164677)</span></li>
<li>/trunk/KDE/kdegames/kollision/ball.h <span style="color: grey">(1164677)</span></li>
<li>/trunk/KDE/kdegames/kollision/ball.cpp <span style="color: grey">(1164677)</span></li>
<li>/trunk/KDE/kdegames/kollision/main.cpp <span style="color: grey">(1164677)</span></li>
<li>/trunk/KDE/kdegames/kollision/mainarea.h <span style="color: grey">(1164677)</span></li>
<li>/trunk/KDE/kdegames/kollision/mainarea.cpp <span style="color: grey">(1164677)</span></li>
<li>/trunk/KDE/kdegames/kollision/pictures/CMakeLists.txt <span style="color: grey">(1164677)</span></li>
<li>/trunk/KDE/kdegames/kollision/renderer.h <span style="color: grey">(1164677)</span></li>
<li>/trunk/KDE/kdegames/kollision/renderer.cpp <span style="color: grey">(1164677)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5059/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>