<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4948/">http://reviewboard.kde.org/r/4948/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've test-compiled it, and my only critique is that the last move marker is too small here. It would fit with a size reduced by about 3*offset, but that indicates that the problem lies deeper. Can you adjust the Z order such that the last move marker is above the board background, but below the grid?</pre>
<br />
<p>- Stefan</p>
<br />
<p>On August 9th, 2010, 8:21 p.m., Brian Croom wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.</div>
<div>By Brian Croom.</div>
<p style="color: grey;"><i>Updated 2010-08-09 20:21:40</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch modifies KReversi to use KGameRenderer for loading its theme and generating/receiving its pixmaps. This is my first port attempt (first KDE contribution woohoo!) so please critique.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tested the various hinting/marking options, changing chip color set, etc. Everything seems to be working.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdegames/kreversi/CMakeLists.txt <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/kreversichip.h <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/kreversichip.cpp <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/kreversirenderer.h <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/kreversirenderer.cpp <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/kreversiscene.h <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/kreversiscene.cpp <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/mainwindow.cpp <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/pics/CMakeLists.txt <span style="color: grey">(1161066)</span></li>
<li>/trunk/KDE/kdegames/kreversi/pics/default_theme.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4948/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>