<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4608/">http://reviewboard.kde.org/r/4608/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 13th, 2010, 7:43 a.m., <b>Stefan Majewsky</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>The changes I suggested are already included in the second revision of the patch, so everything's fine from my side.</pre>
</blockquote>
</blockquote>
<pre>It's in. (rev. 1149609)</pre>
<br />
<p>- Johannes</p>
<br />
<p>On July 12th, 2010, 7:56 p.m., Johannes Löhnert wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Johannes Löhnert.</div>
<p style="color: grey;"><i>Updated 2010-07-12 19:56:52</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Adds runtime rendering of beveled edges to palapeli. The main worker functions are in piecevisuals.cpp. calculateBevelMap() returns a bevel map based on the transparency of the given pixmap. The bevelmap can be used for fast recalculation of the bevel effect (applyBevelMap()) when the piece is rotated. This anticipates that somewhen pieces will be rotatable.
I am quite sure the algorithms do their work :-) - however I am new to Qt and KDE guidelines, so the main point of the request lies on style and conformity.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Tested with a 400 piece puzzle. Memory usage and loading time increased moderately. I animated the bevel rerendering with a quick QTimer hack (not included), which showed realtime or near-realtime performance.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdegames/palapeli/src/engine/mergegroup.cpp <span style="color: grey">(1149154)</span></li>
<li>trunk/KDE/kdegames/palapeli/src/engine/piece.h <span style="color: grey">(1149154)</span></li>
<li>trunk/KDE/kdegames/palapeli/src/engine/piece.cpp <span style="color: grey">(1149154)</span></li>
<li>trunk/KDE/kdegames/palapeli/src/engine/piecevisuals.h <span style="color: grey">(1149154)</span></li>
<li>trunk/KDE/kdegames/palapeli/src/engine/piecevisuals.cpp <span style="color: grey">(1149154)</span></li>
<li>trunk/KDE/kdegames/palapeli/src/engine/scene.h <span style="color: grey">(1149154)</span></li>
<li>trunk/KDE/kdegames/palapeli/src/engine/scene.cpp <span style="color: grey">(1149154)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4608/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://reviewboard.kde.org/r/4608/s/457/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/07/12/edge-bevel_400x100.jpg" style="border: 1px black solid;" alt="How it looks like" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>