Ok. I will do so. I will only use the lines changes for the patch.<br>I hope to get it ready this weekend.<br><br>Thanks for your time<br><br><div class="gmail_quote">2010/3/19 Parker Coates <span dir="ltr"><<a href="mailto:parker.coates@kdemail.net">parker.coates@kdemail.net</a>></span><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im">On Fri, Mar 19, 2010 at 13:53, Andreas Scherf wrote:<br>
> Hi,<br>
> i just have used the option "clean indentation". The problem for now is that i<br>
> would like to rewrite much of the codebase from kbounce to enhance speed and<br>
> remove the open bugs. For example BUG 162527 and BUG 228063.<br>
> But if i always have to wait weeks or month until this would be reviewed this<br>
> would be a pain. You are right, that the diff look awfull, but in the web<br>
> <a href="http://reviewboard.kde.org/r/3077/diff/5/#index_header" target="_blank">http://reviewboard.kde.org/r/3077/diff/5/#index_header</a><br>
> it looks ok.<br>
<br>
</div>That's definitely a weakness of ReviewBoard. I too hadn't realised how<br>
bad the diff was until I downloaded it.<br>
<div class="im"><br>
> I took the orignal kde code formating rules. I even thought that<br>
> im using them. Most of the code has indeed different formating it seems that<br>
> some guys have used differnt editors or differnt indenting rules.<br>
<br>
</div>The official KDE formatting rules really only apply to kdelibs. Other<br>
KDE subprojects may or may not have their own formatting rules. In<br>
KDEGames, each application has its own and the expectation is that new<br>
contributions follow the style of the existing code.<br>
<br>
For cases like this, I would encourage you to write a ".kateconfig"<br>
file in the project directory to override your personal Kate settings<br>
when working in that directory. It can save you a lot of hassle. See<br>
the Killbots directory for an example.<br>
<div class="im"><br>
> My only wish is to rise the quality of kbounce so that it is playable and nice<br>
> for the userbase.<br>
<br>
</div>I certainly understand that and I'm sorry if all this nitpicking has<br>
made us seem ungrateful. The goal of this patch is a good one and we'd<br>
like to see it applied. No question. However, we really have to be<br>
fairly strict about these things as otherwise the codebase will<br>
devolve into a big ugly styling free-for-all. This is especially true<br>
of new contributors (no offence), as there as no guarantee that<br>
they'll stick around to clean up any messes they make.<br>
<br>
KBounce has had way to little attention lately and a few relatively<br>
simple patches like this could do a lot of good. We appreciate them.<br>
<div class="im"><br>
> I think i cancel this patch and start from the beginning. Maybee.<br>
<br>
</div>Personally, I would agree that that is probably the easiest thing at<br>
this point. If I were you, I would:<br>
1. Revert the entire KBounce directory back to current trunk.<br>
2. Work out the correct editor configuration and write a .kateconfig file.<br>
3. Using the current version of the patch on ReviewBoard as a guide<br>
and recreate all the *intentional* changes on top of the clean code<br>
base.<br>
4. Submit the resulting diff as version 5 to ReviewBoard.<br>
<br>
Parker<br>
_______________________________________________<br>
kde-games-devel mailing list<br>
<a href="mailto:kde-games-devel@kde.org">kde-games-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-games-devel" target="_blank">https://mail.kde.org/mailman/listinfo/kde-games-devel</a><br>
</blockquote></div><br>