[Kde-games-devel] Review Request 126043: Hide the hint after the timeout

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126043/#review88978
-----------------------------------------------------------



src/gui/graphicsview/gamescene.cpp (line 92)
<https://git.reviewboard.kde.org/r/126043/#comment60912>

    I think you should use a real QTimer instead of ::singleShot, otherwise if you press the hint button a few times while the hint is still visible things start getting weird. That or disable the hint button while the hints are shown.


- Albert Astals Cid


On nov. 12, 2015, 1:28 p.m., Arseny Krasutsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126043/
> -----------------------------------------------------------
> 
> (Updated nov. 12, 2015, 1:28 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kigo
> 
> 
> Description
> -------
> 
> Hide the hint after the timeout, use the time interval from the preferences, hintVisibleTime()
> 
> 
> Diffs
> -----
> 
>   src/gui/graphicsview/gamescene.cpp fb1ecfc2fad5c36ba13a0b52e8b509c187ddfdb4 
> 
> Diff: https://git.reviewboard.kde.org/r/126043/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arseny Krasutsky
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151130/a57aeaae/attachment.html>