[Bug 276792] devel/cmake*: Make port Makefiles more consistent

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276792

--- Comment #4 from Daniel Engberg <diizzy at FreeBSD.org> ---
Portlint is happy, portclippy isn't but then again it does get some things
wrong and makes Makefiles a lot harder to follow if you were to follow it
completely.

I guess we're going to disagree with this but most if not all ports tries to
follow the "manual flow" which portclippy gets wrong.

Placing CXXFLAGS before configure makes more logical sense as they need to be
defined before getting parsed by whatever build framework or tool the project
(port) is using.

This also goes for build framework related variables,
toggles like CONFIGURE/CMAKE/MESON_ON, _OFF, _ARGS, _ENV. These are preferably
placed at the end right before you define options because that makes more sense
as you likely will use build framework options and increases readbility. It
also makes the Makefile a lot easier to follow and is what we do in the vast
majority of ports.

Anyhow, I've moved it further down now.

Best regards,
Daniel

-- 
You are receiving this mail because:
You are the assignee for the bug.