maintainer-feedback requested: [Bug 272033] graphics/krita: Missing Script Support

[bugzilla-noreply at freebsd.org]

Bugzilla Automation <bugzilla at FreeBSD.org> has asked freebsd-kde (Team)
<kde at FreeBSD.org> for maintainer-feedback:
Bug 272033: graphics/krita: Missing Script Support
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272033



--- Description ---
Krita is supposed to have support for python scripts, and it comes with several
out of the box. However, for some reason, the FreeBSD port for Krita
specifically compiles out that support, thus removing some very useful
functionality from Krita.

Specifically, the Makefile has

    CMAKE_ARGS= -DCMAKE_DISABLE_FIND_PACKAGE_PyQt5:BOOL=true

in it, which makes it so that the build decides that pyqt is not available, and
thus, the python script support is not compiled in.

Using the git repo, I can see that that line was added in

commit 4b59a1f96754873c1d4b5854cdb8a2fd265d6cfa
Author: Tobias C. Berner <tcberner at FreeBSD.org>
Date:	Sat Nov 2 19:17:45 2019 +0000

    graphics/krita: update to 4.2.7.1

Looking at what freshports lists for Krita, I think that that corresponds to
revision 516362 in the SVN repo.

Either way, the commit message unfortunately provides no indication as to why
that line was added to the Makefile. Maybe pyqt had issues at the time, but
that's just a guess. Either way, if the functionality can be reasonably
restored, I'd very much like it to be, since it's very annoying to not have it.

By messing with the port locally, it looks like removing that line from the
Makefile and updating pkg-plist results in a properly working build of Krita
with the python script support (though it's certainly possible that some aspect
of it isn't working properly, and I just haven't hit that). So, from what I can
tell, it shouldn't be a problem to update the Krita port to restore the python
scripts, but I also can only guess as to why it was disabled in the first
place.

I don't know enough about ports to know how dependencies are defined, but
py39-qt5-pyqt isn't currently listed as a dependency for Krita on freshports
(which makes sense given that it's not being used right now), so presumably,
if/when the Krita port is updated to use pyqt again, that dependency will need
to be added.