[kde-freebsd] gpgme upgrade patch

[Doug Barton]

Jason E. Hale wrote:
> On Friday 06 February 2009 15:21:05 Doug Barton wrote:
>>>> The attached patch upgrades gpgme to version 1.1.8. Since the kde
>>>> components are the primary consumers of gpgme, I thought I'd ask y'all
>>>> first to give this a test run.
> 
> I have actually submitted a PR (http://www.freebsd.org/cgi/query-
> pr.cgi?pr=ports/131108) just over a week ago updating gpgme to 1.1.8 and 
> offered to maintain it. 

D'oh! I always forget to check the PR database. I have no objections
to you maintaining the port. I would like you to consider some of the
changes I added though, especially downloading (and optionally
verifying) the .sig file, and making the gpg version optional. I don't
think we should force users to choose one version or the other, and in
my (admittedly minimal) testing gnupg version 1 works just fine. If
you need another copy of my patch, let me know.

Also, FYI there are a few gratuitous changes in your patch (moving
things from one line to another without changing anything) that should
generally be avoided without good reason.

> gabor@ took the PR.

Gabor, what's the status? I am happy to take this one on if you'd prefer.

>> I'm particularly interested in reports saying that this new version of
>> gpgme works with the existing kde apps that make use of this library.
> 
> I have successfully built and used KDE 4.1.4 and KDE 4.2.0 with gpgme 1.1.8.


Good news!

Doug

-- 

    This .signature sanitized for your protection