<table><tr><td style="">jpalecek added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29809">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D29809#674721" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D29809#674721</a>, <a href="https://phabricator.kde.org/p/dfaure/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dfaure</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>The changes you mention don't appear in phabricator.</p>
<p>I suggest amending your commit locally (so there's only one) and then</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">arc diff HEAD~</pre></div></div>
</blockquote>
<p>Just to clarify. I of course have it as one commit locally, but I have them more on a branch and develop and test them together. So when I was amending the individual commits I made an error in distributing the changes.</p>
<p>Then I don't use <tt style="background: #ebebeb; font-size: 13px;">arc</tt> because it doesn't work, totally. It just reports some error about missing key and exits. From the network communication I found out this is caused by requests to the phabricator server missing the query parameters when reusing HTTP connection fails, however, I don't want to dig deeper into this as it is something between php and curl. Oddly enough it doesn't work on this repository <em>only</em>, other kde repositories work.</p>
<p>And please, if you accepted it, could you also commit it, with the other 2 revisions? I have no commit access.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R285 KCrash</div></div></div><br /><div><strong>BRANCH</strong><div><div>for-upstream</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29809">https://phabricator.kde.org/D29809</a></div></div><br /><div><strong>To: </strong>jpalecek, Frameworks, dfaure<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>