<table><tr><td style="">wojnilowicz marked an inline comment as done.<br />wojnilowicz added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29258">View Revision</a></tr></table><br /><div><div><p>Thanks for looking into that matter.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D29258#674489" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D29258#674489</a>, <a href="https://phabricator.kde.org/p/brute4s99/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@brute4s99</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I still do not understand the utility of this patch. What do you hope to fix by this patch exactly?</p></div>
</blockquote>
<p>I hope to fix KNotifications build on MSYS2 where there is no possibility to compile SnoreToast.<br />
It was possible to compile KNotifications without neither compiling SnoreToast, nor downloading its binaries before. This patch brings that possibility while allowing to build with SnoreToast enabled as well.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>SnoreToast fails to build on MSYS2 due to missing<br />
which apparently is not available for this compiler.</p></blockquote>
<p>which compiler are you referring to here?</p></blockquote>
<p>MinGW from MSYS2.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>This patch changes dependency on SnoreToast from required to optional.<br />
As a result, it allows to actually build KNotifications on MSYS2.</p></blockquote>
<p>why do you want to build KNotifications on MSYS2?</p></blockquote>
<p>I have my own build of KF5 libraries which I use to package app that I forked.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>More inline comments follow, please take a look.</p></blockquote>
</div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29258#inline-171361">View Inline</a><span style="color: #4b4d51; font-weight: bold;">brute4s99</span> wrote in <span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:76</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">why do we need Qt5Network for all kinds of Windows builds?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We don't need it, but if it would be found together with SnoreToast then SnoreToast would be enabled by default in MSVC and MSYS2 builds.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29258#inline-171362">View Inline</a><span style="color: #4b4d51; font-weight: bold;">brute4s99</span> wrote in <span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:79</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">the option should be MSYS specific rather than being SnoreToast specific.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think it should be SnoreToast specific because if you download the binary of SnoreToast then you could possibly compile KNotifications with it on MSYS2.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R289 KNotifications</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29258">https://phabricator.kde.org/D29258</a></div></div><br /><div><strong>To: </strong>wojnilowicz, broulik, brute4s99, vonreth<br /><strong>Cc: </strong>vonreth, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>