<table><tr><td style="">jpalecek added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29814">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D29814#674013" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D29814#674013</a>, <a href="https://phabricator.kde.org/p/dfaure/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dfaure</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I'm a bit confused by the bug this is fixing. Surely this doesn't happen to all cases of crashes without autorestart enabled??</p>
<p>Also, it sounds like a null check might be enough.</p></div>
</blockquote>
<p>No. It is a crash where <tt style="background: #ebebeb; font-size: 13px;">s_autoRestartCommandLine</tt> was null. The actual crash happened in the logging code, but it is also used in <tt style="background: #ebebeb; font-size: 13px;">startProcess</tt> and I think going for non-null <tt style="background: #ebebeb; font-size: 13px;">s_autoRestartCommandLine</tt> is actually easier than faffing with null pointer checks and special casing in the signal handler code. Even with no restart arguments, you still need <tt style="background: #ebebeb; font-size: 13px;">argv</tt> to hold the executable name to restart, so why not maintain it uniformly? It only costs a few bytes of heap.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29814#inline-171178">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">kcrash.cpp:107</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Should this become 1 then? Otherwise the <tt style="background: #ebebeb; font-size: 13px;">for</tt> loop won't delete that new <tt style="background: #ebebeb; font-size: 13px;">new char*[1]</tt></p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No. The invariant is that <tt style="background: #ebebeb; font-size: 13px;">s_autoRestartArgc</tt> is the number of arguments, not counting the last <tt style="background: #ebebeb; font-size: 13px;">null</tt>. The <tt style="background: #ebebeb; font-size: 13px;">new char*[1]</tt> is deleted after the loop.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29814#inline-171179">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">kcrash.cpp:272</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">insert(0) reads like prepend, but args is empty anyway, why not just use append?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Well I was thinking about <tt style="background: #ebebeb; font-size: 13px;">resize()</tt>, then found there wasn't any. However, if we want to be clear, maybe <tt style="background: #ebebeb; font-size: 13px;">args = { QString() }</tt> would be the best?</p>
<p style="padding: 0; margin: 8px;">(In reality, the effect should be <tt style="background: #ebebeb; font-size: 13px;">args = { filePath }</tt>, but that comes with the next line.)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R285 KCrash</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29814">https://phabricator.kde.org/D29814</a></div></div><br /><div><strong>To: </strong>jpalecek, Frameworks, dfaure<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>