<table><tr><td style="">nicolasfella requested changes to this revision.<br />nicolasfella added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29358">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29358#inline-170894">View Inline</a><span style="color: #4b4d51; font-weight: bold;">notifybyandroid.cpp:110</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">n</span><span class="p">.</span><span class="n">setField</span><span class="p">(</span><span style="color: #766510">"urgency"</span><span class="p">,</span> <span class="p">(</span><span class="n">jint</span><span class="p">)(</span><span class="n">notification</span><span style="color: #aa2211">-></span><span class="n">urgency</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">KNotification</span><span style="color: #aa2211">::</span><span class="n">DefaultUrgency</span> <span style="color: #aa2211">?</span> <span class="n">KNotification</span><span style="color: #aa2211">::</span><span style="color: #a0a000">HighUrgency</span> <span class="p">:</span> <span class="n">notification</span><span style="color: #aa2211">-></span><span class="n">urgency</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">n</span><span class="p">.</span><span class="n">setField</span><span class="p">(</span><span style="color: #766510">"visibility"</span><span class="p">,</span> <span class="n">QAndroidJniObject</span><span style="color: #aa2211">::</span><span class="n">fromString</span><span class="p">(</span><span class="n">notification</span><span style="color: #aa2211">-></span><span class="n">hints</span><span class="p">().</span><span class="n">value</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"visibility"</span><span class="p">)).</span><span class="n">toString</span><span class="p">().</span><span class="n">toLower</span><span class="p">()).</span><span class="n">object</span><span style="color: #aa2211"><</span><span class="n">jstring</span><span style="color: #aa2211">></span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The hint name should be something like x-kde-visibility</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R289 KNotifications</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29358">https://phabricator.kde.org/D29358</a></div></div><br /><div><strong>To: </strong>vkrause, nicolasfella<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>