<table><tr><td style="">dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29782">View Revision</a></tr></table><br /><div><div><p>Can you add a unittest for a KIO::mostLocalUrl() in testtrash.cpp (which is :local, so it should work)<br />
and another one in jobtest.cpp for a http URL (e.g. to test which error code we're getting, if any?)</p>
<p>+ call mostLocalUrl() on a "normal" StatJob in testtrash.cpp</p>
<p>Thanks.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29782">https://phabricator.kde.org/D29782</a></div></div><br /><div><strong>To: </strong>ahmadsamir, Frameworks, dfaure, sitter<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>