<table><tr><td style="">ahmadsamir added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29547">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29547#inline-169442">View Inline</a><span style="color: #4b4d51; font-weight: bold;">krun.h:216</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d"> * @deprecated since 5.6, use runApplication instead.<span class="bright"> No change needed on the application side,</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d"> * <span class="bright">the only differe</span>nce <span class="bright">is the return value (qint64</span> instead<span class="bright"> of bool)</span>.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * @deprecated since 5.6, use runApplication instead.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * <span class="bright">@deprecated si</span>nce <span class="bright">5.71, use ApplicationLauncherJob</span> instead.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * @code</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't think you want both <span class="phabricator-remarkup-mention-unknown">@deprecated</span>?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29547#inline-169300">View Inline</a><span style="color: #4b4d51; font-weight: bold;">krun.h:229</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">KIOWIDGETS_DEPRECATED_VERSION</span><span class="p">(</span><span style="color: #601200">5</span><span class="p">,</span> <span style="color: #601200">6</span><span class="p">,</span> <span style="color: #766510">"Use K<span class="bright">Run::runApplication(const KService &, const QList<QUrl> &, QWidget *, RunFlags, const QString &, const QByteArray &</span>"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KIOWIDGETS_DEPRECATED_VERSION</span><span class="p">(</span><span style="color: #601200">5</span><span class="p">,</span> <span style="color: #601200">6</span><span class="p">,</span> <span style="color: #766510">"Use K<span class="bright">IO::ApplicationLauncherJob, see API docs for a code sample</span>"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">static</span> <span style="color: #aa4000">bool</span> <span class="n">run</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">KService</span> <span style="color: #aa2211">&</span><span class="n">service</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">QUrl</span><span style="color: #aa2211">></span> <span style="color: #aa2211">&</span><span class="n">urls</span><span class="p">,</span> <span class="n">QWidget</span> <span style="color: #aa2211">*</span><span class="n">window</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You meant "5, 71"</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29547#inline-169444">View Inline</a><span style="color: #4b4d51; font-weight: bold;">krun.h:369</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> * @return @c true on success, @c false on error</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #74777d"> * @deprecated since 5.31, use <span class="bright">ru</span>nUrl<span class="bright">() with RunFlags</span> instead.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * @deprecated since 5.31, use <span class="bright">Ope</span>nUrl<span class="bright">Job</span> instead.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * @code</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">But OpenUrlJob is in 5.71 not 5.31? people will be reading that on api.kde.org not only in 5.71 header files, right?<br />
maybe:<br />
<span class="phabricator-remarkup-mention-unknown">@deprecated</span> since 5.31<br />
Since 5.71, use OpenUrlJob instead.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29547#inline-169445">View Inline</a><span style="color: #4b4d51; font-weight: bold;">krun.h:380</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">KIOWIDGETS_DEPRECATED_VERSION</span><span class="p">(</span><span style="color: #601200">5</span><span class="p">,</span> <span style="color: #601200">31</span><span class="p">,</span> <span style="color: #766510">"Use K<span class="bright">Run::const QUrl &, const QString &, QWidget *, RunFlags, const QString &, const QByteArray &</span>"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KIOWIDGETS_DEPRECATED_VERSION</span><span class="p">(</span><span style="color: #601200">5</span><span class="p">,</span> <span style="color: #601200">31</span><span class="p">,</span> <span style="color: #766510">"Use K<span class="bright">IO::OpenUrlJob, see API docs for a code sample</span>"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">static</span> <span style="color: #aa4000">bool</span> <span class="n">runUrl</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QUrl</span> <span style="color: #aa2211">&</span><span class="n">url</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">mimetype</span><span class="p">,</span> <span class="n">QWidget</span> <span style="color: #aa2211">*</span><span class="n">window</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The same issue 5.31 vs 5.71.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29547#inline-169447">View Inline</a><span style="color: #4b4d51; font-weight: bold;">krun.h:452</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> * @param asn Application startup notification id, if any (otherwise "").</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> * @return @c true on success, @c false on error</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> * @code</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Missing <span class="phabricator-remarkup-mention-unknown">@deprecated</span>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29547#inline-169448">View Inline</a><span style="color: #4b4d51; font-weight: bold;">krun.h:599</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">void</span> <span class="n">slotTimeout</span><span class="p">();<span class="bright"></span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">// KDE5: rename to slotNextStep() or something like that</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span class="n">slotTimeout</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">So, you're keeping the name slotTimout? I guess after 5-10 years, no point changing it :)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29547">https://phabricator.kde.org/D29547</a></div></div><br /><div><strong>To: </strong>dfaure, ahmadsamir, broulik, svuorela<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>