<table><tr><td style="">kossebau created this revision.<br />kossebau added reviewers: Frameworks, dfaure.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />kossebau requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29572">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>To also support EXCLUDE_DEPRECATED_BEFORE_AND_AT=5.69.0 properly some<br />
more if-elif would have been needed, making the code more hard to read.<br />
Based on dicussion on #kde-devel with dfaure that has been left out,<br />
for some future non-version-based *_BUILD_DEPRECATED.<br />
So the focus already is on building without any own deprecated API,<br />
no-one is expected to use EXCLUDE_DEPRECATED_BEFORE_AND_AT with a<br />
certain version != CURREENT or 0.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0 (default) or CURRENT,<br />
all unit tests pass.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R309 KService</div></div></div><br /><div><strong>BRANCH</strong><div><div>buildwithoutdeprecated</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29572">https://phabricator.kde.org/D29572</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/kplugininfotest.cpp<br />
autotests/kservicetest.cpp<br />
autotests/kservicetest.h<br />
src/services/kmimetypetrader.cpp<br />
src/services/kservicefactory.cpp<br />
src/services/kserviceoffer.cpp<br />
src/services/kserviceoffer.h<br />
src/services/kservicetypeprofile.cpp<br />
src/services/kservicetypeprofile.h<br />
src/services/kservicetypetrader.cpp<br />
src/sycoca/kbuildservicefactory.cpp<br />
src/sycoca/kmimeassociations.cpp</div></div></div><br /><div><strong>To: </strong>kossebau, Frameworks, dfaure<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>