<table><tr><td style="">cblack added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29534">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29534#inline-169208">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SpinBox.qml:49</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">wheel</span><span class="p">.</span><span style="color: #004012">angleDelta</span><span class="p">.</span><span style="color: #004012">y</span> <span style="color: #aa2211">></span> <span style="color: #601200">0</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">value</span> <span style="color: #aa2211"><=</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">to</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">value</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">parseInt</span><span class="p">(</span><span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">value</span><span class="p">,</span> <span style="color: #601200">10</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">stepSize</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">valueModified</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">control.value</tt> is already a numeric type as <tt style="background: #ebebeb; font-size: 13px;">control</tt> is a SpinBox, so you don't need to <tt style="background: #ebebeb; font-size: 13px;">parseInt</tt> here. <tt style="background: #ebebeb; font-size: 13px;">control.value =+ control.stepSize</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29534#inline-169210">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SpinBox.qml:50</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">value</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">parseInt</span><span class="p">(</span><span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">value</span><span class="p">,</span> <span style="color: #601200">10</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">stepSize</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">valueModified</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">wheel</span><span class="p">.</span><span style="color: #004012">angleDelta</span><span class="p">.</span><span style="color: #004012">y</span> <span style="color: #aa2211"><</span> <span style="color: #601200">0</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">value</span> <span style="color: #aa2211">>=</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">from</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think you would need to explicitly call this on <tt style="background: #ebebeb; font-size: 13px;">control</tt>? <tt style="background: #ebebeb; font-size: 13px;">control.valueModified()</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29534#inline-169209">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SpinBox.qml:52</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">wheel</span><span class="p">.</span><span style="color: #004012">angleDelta</span><span class="p">.</span><span style="color: #004012">y</span> <span style="color: #aa2211"><</span> <span style="color: #601200">0</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">value</span> <span style="color: #aa2211">>=</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">from</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">value</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">parseInt</span><span class="p">(</span><span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">value</span><span class="p">,</span> <span style="color: #601200">10</span><span class="p">)</span> <span style="color: #aa2211">-</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">stepSize</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">valueModified</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">control.value =- control.stepSize</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29534#inline-169211">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SpinBox.qml:53</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">value</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">parseInt</span><span class="p">(</span><span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">value</span><span class="p">,</span> <span style="color: #601200">10</span><span class="p">)</span> <span style="color: #aa2211">-</span> <span style="color: #004012">control</span><span class="p">.</span><span style="color: #004012">stepSize</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">valueModified</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">control.valueModified()</tt>.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29534">https://phabricator.kde.org/D29534</a></div></div><br /><div><strong>To: </strong>ngraham, VDG, Plasma<br /><strong>Cc: </strong>cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns<br /></div>