<table><tr><td style="">leinir accepted this revision.<br />leinir added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29451">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D29451#665420" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D29451#665420</a>, <a href="https://phabricator.kde.org/p/alex/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@alex</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Fix connect</p>
<p>Thanks, I wasn't aware of that until now :-)</p></div>
</blockquote>
<p>Same, until a couple of weeks ago :D i'd sort of... taken to doing it anyway, because it just seemed nice, but yup, turns out that you really definitely want to do that unless you know very precisely what you're doing :)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29451#inline-168946">View Inline</a><span style="color: #4b4d51; font-weight: bold;">installation.cpp:355</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QProcess</span><span style="color: #aa2211">*</span> <span class="n">p</span> <span style="color: #aa2211">=</span> <span class="n">runPostInstallationCommand</span><span class="p">(</span><span class="n">installedFiles</span><span class="p">.</span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #601200">1</span> <span style="color: #aa2211">?</span> <span class="n">installedFiles</span><span class="p">.</span><span class="n">first</span><span class="p">()</span> <span style="color: #aa2211">:</span> <span class="n">targetPath</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">connect</span><span class="p">(</span><span class="n">p</span><span class="p">,</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span style="color: #aa4000">void</span><span class="p">(</span><span class="n">QProcess</span><span style="color: #aa2211">::*</span><span class="p">)(</span><span style="color: #aa4000">int</span><span class="p">,</span> <span class="n">QProcess</span><span style="color: #aa2211">::</span><span class="n">ExitStatus</span><span class="p">)</span><span style="color: #aa2211">></span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">QProcess</span><span style="color: #aa2211">::</span><span class="n">finished</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">,<span class="bright"></span></span><span class="bright"> </span><span class="n"><span class="bright">installationFinished</span></span><span class="bright"></span><span class="p"><span class="bright">);</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">p</span><span class="p">,</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span style="color: #aa4000">void</span><span class="p">(</span><span class="n">QProcess</span><span style="color: #aa2211">::*</span><span class="p">)(</span><span style="color: #aa4000">int</span><span class="p">,</span> <span class="n">QProcess</span><span style="color: #aa2211">::</span><span class="n">ExitStatus</span><span class="p">)</span><span style="color: #aa2211">></span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">QProcess</span><span style="color: #aa2211">::</span><span class="n">finished</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">[</span><span class="n">entry</span><span class="p">,</span> <span class="n">installationFinished</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">]</span> <span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">exitCode</span><span class="p">,</span> <span class="n">QProcess</span><span style="color: #aa2211">::</span><span class="n">ExitStatus</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Terribly sorry to keep doing this, but... yeah, noticed the old-style overload thing, but since we require higher than Qt 5.6 and already require a sufficiently high version of c++, we can use qOverload instead of the static_cast :) <a href="https://doc.qt.io/qt-5/qtglobal.html#qOverload" class="remarkup-link" target="_blank" rel="noreferrer">https://doc.qt.io/qt-5/qtglobal.html#qOverload</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br /><div><strong>BRANCH</strong><div><div>arcpatch-D29451</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29451">https://phabricator.kde.org/D29451</a></div></div><br /><div><strong>To: </strong>alex, KNewStuff, ngraham, leinir<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>