<table><tr><td style="">dfaure updated this revision to Diff 82058.<br />dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29385">View Revision</a></tr></table><br /><div><div><p>-void KIO::OpenUrlJob::setRunFlags(KIO::ApplicationLauncherJob::RunFlags runFlags)<br />
+void KIO::OpenUrlJob::setDeleteTemporaryFile(bool b)</p>

<p>The more I think about it, the least I like the use of flags here.</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">they are from the wrong class as Kai-Uwe pointed out, but more importantly:</li>
<li class="remarkup-list-item">the other bool setters here are for unrelated concerns, better keep them separate.</li>
</ol>

<p>Are we doing lineEdit->setDragEnabled(true); lineEdit->setClearButtonEnabled(true); lineEdit->setReadOnly(true);<br />
or are we doing lineEdit->setFlags(QLineEdit::DragEnabled | QLineEdit::ClearButtonEnabled | QLineEdit::ReadOnly)?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D29385?vs=81840&id=82058">https://phabricator.kde.org/D29385?vs=81840&id=82058</a></div></div><br /><div><strong>BRANCH</strong><div><div>2020_05_openurljob</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29385">https://phabricator.kde.org/D29385</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/CMakeLists.txt<br />
autotests/krununittest.cpp<br />
autotests/openurljobtest.cpp<br />
autotests/openurljobtest.h<br />
src/core/kurlauthorized.h<br />
src/gui/CMakeLists.txt<br />
src/gui/applicationlauncherjob.cpp<br />
src/gui/applicationlauncherjob.h<br />
src/gui/openurljob.cpp<br />
src/gui/openurljob.h<br />
src/gui/openurljobhandlerinterface.cpp<br />
src/gui/openurljobhandlerinterface.h<br />
src/widgets/CMakeLists.txt<br />
src/widgets/jobuidelegate.cpp<br />
src/widgets/kdesktopfileactions.cpp<br />
src/widgets/kopenwithdialog.cpp<br />
src/widgets/kopenwithdialog.h<br />
src/widgets/krun.cpp<br />
src/widgets/widgetsopenurljobhandler.cpp<br />
src/widgets/widgetsopenurljobhandler.h</div></div></div><br /><div><strong>To: </strong>dfaure, ahmadsamir, broulik, meven, kossebau, davidedmundson, nicolasfella, svuorela<br /><strong>Cc: </strong>feverfew, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>