<table><tr><td style="">broulik requested changes to this revision.<br />broulik added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29479">View Revision</a></tr></table><br /><div><div><p>Notifications don't use <tt style="background: #ebebeb; font-size: 13px;">PlasmoidHeading</tt></p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29479#inline-168771">View Inline</a><span style="color: #4b4d51; font-weight: bold;">PlasmoidHeading.qml:71</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">enabledBorders:</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">var</span> <span style="color: #004012">borders</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span style="color: #304a96">Array</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">borders</span> <span style="color: #aa2211">|=</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">FrameSvg</span><span class="p">.</span><span style="color: #004012">LeftBorder</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use <tt style="background: #ebebeb; font-size: 13px;">[]</tt> instead of <tt style="background: #ebebeb; font-size: 13px;">new Array()</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29479#inline-168770">View Inline</a><span style="color: #4b4d51; font-weight: bold;">PlasmoidHeading.qml:72</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">var</span> <span style="color: #004012">borders</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span style="color: #304a96">Array</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">borders</span> <span style="color: #aa2211">|=</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">FrameSvg</span><span class="p">.</span><span style="color: #004012">LeftBorder</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">borders</span> <span style="color: #aa2211">|=</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">FrameSvg</span><span class="p">.</span><span style="color: #004012">RightBorder</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">How is operator <tt style="background: #ebebeb; font-size: 13px;">|=</tt> supposed to work with an <tt style="background: #ebebeb; font-size: 13px;">Array</tt>?!</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29479#inline-168772">View Inline</a><span style="color: #4b4d51; font-weight: bold;">PlasmoidHeading.qml:74</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">borders</span> <span style="color: #aa2211">|=</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">FrameSvg</span><span class="p">.</span><span style="color: #004012">RightBorder</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">plasmoid</span><span class="p">.</span><span style="color: #004012">location</span> <span style="color: #aa2211">!==</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">Types</span><span class="p">.</span><span style="color: #004012">TopEdge</span> <span style="color: #aa2211">||</span> <span style="color: #004012">location</span> <span style="color: #aa2211">!=</span> <span style="color: #004012">PlasmoidHeading</span><span class="p">.</span><span style="color: #004012">Location</span><span class="p">.</span><span style="color: #004012">Header</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">borders</span> <span style="color: #aa2211">|=</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">FrameSvg</span><span class="p">.</span><span style="color: #004012">TopBorder</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Where is <tt style="background: #ebebeb; font-size: 13px;">plasmoid</tt> defined?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29479#inline-168774">View Inline</a><span style="color: #4b4d51; font-weight: bold;">plasmoidheading.svg:9</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <path id="hint-stretch-borders" d="m-7-<span class="bright">7</span>h5v5h-5z" opacity=".6"/>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <path id="header-center" class="ColorScheme-Background" d="m19 1<span class="bright">2</span>h32v32h-32z" fill="currentColor" opacity=".75"/>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <path id="header-right" class="ColorScheme-Background" d="m5<span class="bright">1 12</span>h6v32h-6z" fill="currentColor" opacity=".75"/>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <path id="hint-stretch-borders" d="m-7-<span class="bright">6.999998</span>h5v5h-5z" opacity=".6"/>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <path id="header-center" class="ColorScheme-Background" d="m19 1<span class="bright">1.999983</span>h32v32h-32z" fill="currentColor" opacity=".75"/>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <path id="header-right" class="ColorScheme-Background" d="m5<span class="bright">0.999981 11.999983</span>h6v32h-6z" fill="currentColor" opacity=".75"/>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You've just added a gazillion non-integer coordinates</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29479">https://phabricator.kde.org/D29479</a></div></div><br /><div><strong>To: </strong>niccolove, Plasma, broulik<br /><strong>Cc: </strong>broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns<br /></div>