<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29397">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29397#inline-168199">View Inline</a><span style="color: #4b4d51; font-weight: bold;">previewjob.cpp:717</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="bright"></span><span class="n"><span class="bright">str</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">>></span></span><span class="bright"> </span><span class="n"><span class="bright">width</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">>></span></span><span class="bright"> </span><span class="n"><span class="bright">height</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">>></span></span><span class="bright"> </span><span class="n"><span class="bright">iFormat</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="bright"></span><span class="n"><span class="bright">qreal</span></span><span class="bright"> </span><span class="n"><span class="bright">imgDevicePixelRatio</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">str</span> <span style="color: #aa2211">>></span> <span class="n">width</span> <span style="color: #aa2211">>></span> <span class="n">height</span> <span style="color: #aa2211">>></span> <span class="n">iFormat</span> <span style="color: #aa2211">>></span> <span class="n">imgDevicePixelRatio</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">QImage</span><span style="color: #aa2211">::</span><span class="n">Format</span> <span class="n">format</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">QImage</span><span style="color: #aa2211">::</span><span class="n">Format</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">iFormat</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This here also breaks compatibility. Add a KF6 TODO to start the serialization with a version number.</p>

<p style="padding: 0; margin: 8px;">Meanwhile a hack is needed, like <tt style="background: #ebebeb; font-size: 13px;">if (iFormat & 0x1000) { iFormat &= 0xFFF; str >> imgDevicePixelRatio; }</tt><br />
and of course setting that 0x1000 flag in the slaves that have been updated to provide the pixelratio.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29397#inline-168198">View Inline</a><span style="color: #4b4d51; font-weight: bold;">thumbcreator.h:183</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="n">class</span> <span style="color: #004012">KIOWIDGETS_DEPRECATED_VERSION</span><span class="p">(</span><span style="color: #601200">5</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #766510">"Use ThumbCreator"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="n">KIOWIDGETS_EXPORT</span> <span style="color: #a0a000">ThumbCreatorV2</span> <span class="p">:</span> <span class="n">public</span> <span class="n">ThumbCreator</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You need to do like we once did: define an interface that inherits from ThumbCreator.<br />
Call it V3....</p>

<p style="padding: 0; margin: 8px;">In the job, use dynamic_cast to test whether the object provided by the kioslave supports the V3 interface or not.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29397">https://phabricator.kde.org/D29397</a></div></div><br /><div><strong>To: </strong>meven, dfaure, broulik, Frameworks<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>