<table><tr><td style="">dfaure updated this revision to Diff 81830.<br />dfaure marked an inline comment as done.<br />dfaure added a comment.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29385">View Revision</a></tr></table><br /><div><div><p>Multiple fixes thanks to review comments; didn't remove the fast path yet (a unittest needs fixup)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D29385?vs=81814&id=81830">https://phabricator.kde.org/D29385?vs=81814&id=81830</a></div></div><br /><div><strong>BRANCH</strong><div><div>2020_05_openurljob</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29385">https://phabricator.kde.org/D29385</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/CMakeLists.txt<br />

autotests/krununittest.cpp<br />

autotests/openurljobtest.cpp<br />

autotests/openurljobtest.h<br />

src/core/kurlauthorized.h<br />

src/gui/CMakeLists.txt<br />

src/gui/applicationlauncherjob.cpp<br />

src/gui/applicationlauncherjob.h<br />

src/gui/openurljob.cpp<br />

src/gui/openurljob.h<br />

src/gui/openurljobhandlerinterface.cpp<br />

src/gui/openurljobhandlerinterface.h<br />

src/widgets/CMakeLists.txt<br />

src/widgets/jobuidelegate.cpp<br />

src/widgets/kdesktopfileactions.cpp<br />

src/widgets/kopenwithdialog.cpp<br />

src/widgets/kopenwithdialog.h<br />

src/widgets/krun.cpp<br />

src/widgets/widgetsopenurljobhandler.cpp<br />

src/widgets/widgetsopenurljobhandler.h</div></div></div><br /><div><strong>To: </strong>dfaure, ahmadsamir, broulik, meven, kossebau, davidedmundson, nicolasfella, svuorela<br /><strong>Cc: </strong>feverfew, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>