<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29231">View Revision</a></tr></table><br /><div><div><p>Let's wait for the new kwaylandserver repo before pushing.</p>

<p>But ++, looks good.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29231#inline-167358">View Inline</a><span style="color: #4b4d51; font-weight: bold;">keyboard_shortcuts_inhibit_interface.cpp:21</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">class</span> <span style="color: #00702a">KeyboardShortcutsInhibitorInterface</span><span style="color: #aa2211">::</span><span style="color: #a0a000">Private</span> <span class="p">:</span> <span style="color: #aa4000">public</span> <span class="n">QtWaylandServer</span><span style="color: #aa2211">::</span><span class="n">zwp_keyboard_shortcuts_inhibitor_v1</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Q_DECL_PRIVATE</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29231#inline-167355">View Inline</a><span style="color: #4b4d51; font-weight: bold;">keyboard_shortcuts_inhibit_interface.cpp:35</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">KeyboardShortcutsInhibitorInterface</span><span style="color: #aa2211">::</span><span class="n">Private</span><span style="color: #aa2211">::</span><span class="n">Private</span><span class="p">(</span><span class="n">wl_resource</span> <span style="color: #aa2211">*</span><span class="n">resource</span><span class="p">,</span> <span style="color: #aa4000">int</span> <span class="n">id</span><span class="p">,</span> <span class="n">SurfaceInterface</span> <span style="color: #aa2211">*</span><span class="n">surface</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                                      <span class="n">SeatInterface</span> <span style="color: #aa2211">*</span><span class="n">seat</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It's not clear what resource this argument is referring to.</p>

<p style="padding: 0; margin: 8px;">I think from reading the code it's the resource of the manager? At which point "parentResource" would be a better name.</p>

<p style="padding: 0; margin: 8px;">Or separate client, id, version args.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29231">https://phabricator.kde.org/D29231</a></div></div><br /><div><strong>To: </strong>bport, zzag, davidedmundson, apol<br /><strong>Cc: </strong>romangg, crossi, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>