<table><tr><td style="">crossi added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29231">View Revision</a></tr></table><br /><div><div><p>some code style related comments</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29231#inline-167342">View Inline</a><span style="color: #4b4d51; font-weight: bold;">test_keyboard_shortcuts_inhibitor_interface.cpp:109</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_manager</span> <span style="color: #aa2211">=</span> <span class="n">m_display</span><span class="p">.</span><span class="n">createKeyboardShortcutsInhibitManager</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">     <span class="n">QVERIFY</span><span class="p">(</span><span class="n">m_serverCompositor</span><span style="color: #aa2211">-></span><span class="n">isValid</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">connect</span><span class="p">(</span><span class="n">m_serverCompositor</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">CompositorInterface</span><span style="color: #aa2211">::</span><span class="n">surfaceCreated</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">](</span><span class="n">SurfaceInterface</span> <span style="color: #aa2211">*</span><span class="n">surface</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">indentation</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29231#inline-167343">View Inline</a><span style="color: #4b4d51; font-weight: bold;">test_keyboard_shortcuts_inhibitor_interface.cpp:154</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">i</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span> <span class="n">i</span> <span style="color: #aa2211"><</span> <span style="color: #601200">3</span><span class="p">;</span> <span style="color: #aa2211">++</span><span class="n">i</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">KWayland</span><span style="color: #aa2211">::</span><span class="n">Client</span><span style="color: #aa2211">::</span><span class="n">Surface</span> <span style="color: #aa2211">*</span><span class="n">s</span> <span style="color: #aa2211">=</span><span class="n">m_clientCompositor</span><span style="color: #aa2211">-></span><span class="n">createSurface</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">m_clientSurfaces</span> <span style="color: #aa2211">+=</span> <span class="n">s</span><span style="color: #aa2211">-></span><span style="color: #aa4000">operator</span> <span class="n">wl_surface</span> <span style="color: #aa2211">*</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">add space after =</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29231#inline-167345">View Inline</a><span style="color: #4b4d51; font-weight: bold;">display.h:328</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">     */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">KeyboardShortcutsInhibitManagerInterface</span> <span style="color: #aa2211">*</span><span style="color: #004012">createKeyboardShortcutsInhibitManager</span><span class="p">(</span><span class="n">QObject</span> <span style="color: #aa2211">*</span><span class="n">object</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">parameter should be <tt style="background: #ebebeb; font-size: 13px;">QObject *parent = nullptr</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29231#inline-167353">View Inline</a><span style="color: #4b4d51; font-weight: bold;">keyboard_shortcuts_inhibit_interface.h:69</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">friend</span> <span class="n">class</span> <span class="n">KeyboardShortcutsInhibitorInterface</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">explicit</span> <span style="color: #004012">KeyboardShortcutsInhibitManagerInterface</span><span class="p">(</span><span class="n">Display</span> <span style="color: #aa2211">*</span><span class="n">d</span><span class="p">,</span> <span class="n">QObject</span> <span style="color: #aa2211">*</span><span class="n">parent</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">void</span> <span style="color: #004012">removeInhibitor</span><span class="p">(</span><span class="n">SurfaceInterface</span> <span style="color: #aa2211">*</span><span style="color: #aa4000">const</span> <span class="n">surface</span><span class="p">,</span> <span class="n">SeatInterface</span> <span style="color: #aa2211">*</span><span style="color: #aa4000">const</span> <span class="n">seat</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">parent parameter should be defaulted to nullptr</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29231">https://phabricator.kde.org/D29231</a></div></div><br /><div><strong>To: </strong>bport, zzag, davidedmundson, apol<br /><strong>Cc: </strong>romangg, crossi, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>