<table><tr><td style="">zzag requested changes to this revision.<br />zzag added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28882">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>In future, it might be faster to put up just the interface xml for review first.</p></blockquote>
<p>++</p>
<hr class="remarkup-hr" />
<p>What about using existing <tt style="background: #ebebeb; font-size: 13px;">wl_output</tt> objects? The <tt style="background: #ebebeb; font-size: 13px;">add_source</tt> event can be simplified quite a lot (even maybe dropped). For windows, we could use string handles.</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="xml" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #00702a"><request</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"record_monitor"</span><span style="color: #00702a">></span>
<span style="color: #00702a"><description/></span>
<span style="color: #00702a"><arg</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"id"</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"new_id"</span> <span style="color: #354bb3">interface=</span><span style="color: #766510">"zkde_screencast_stream_v1"</span><span style="color: #00702a">/></span>
<span style="color: #00702a"><arg</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"output"</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"object"</span> <span style="color: #354bb3">interface=</span><span style="color: #766510">"wl_output"</span><span style="color: #00702a">/></span>
<span style="color: #00702a"></request></span>
<span style="color: #00702a"><request</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"record_window"</span><span style="color: #00702a">></span>
<span style="color: #00702a"><description/></span>
<span style="color: #00702a"><arg</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"id"</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"new_id"</span> <span style="color: #354bb3">interface=</span><span style="color: #766510">"zkde_screencast_stream_v1"</span><span style="color: #00702a">/></span>
<span style="color: #00702a"><arg</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"handle"</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"string"</span><span style="color: #00702a">/></span>
<span style="color: #00702a"></request></span></pre></div>
<p>Please notice that the manager object also needs to advertise supported cursor modes</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="xml" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #00702a"><enum</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"cursor_mode"</span><span style="color: #00702a">></span>
<span style="color: #00702a"><entry</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"hidden"</span> <span style="color: #354bb3">value=</span><span style="color: #766510">"0"</span>
<span style="color: #354bb3">summary=</span><span style="color: #766510">"the cursor is not part of the screen cast stream"</span><span style="color: #00702a">/></span>
<span style="color: #00702a"><entry</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"metadata"</span> <span style="color: #354bb3">value=</span><span style="color: #766510">"1"</span>
<span style="color: #354bb3">summary=</span><span style="color: #766510">"the cursor is not part of the screen cast stream, but sent as PipeWire metadata"</span><span style="color: #00702a">/></span>
<span style="color: #00702a"><entry</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"embedded"</span> <span style="color: #354bb3">value=</span><span style="color: #766510">"2"</span>
<span style="color: #354bb3">summary=</span><span style="color: #766510">"the cursor is embedded as part of the stream buffers"</span><span style="color: #00702a">/></span>
<span style="color: #00702a"></enum></span>
<span style="color: #00702a"><event</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"cursor_mode"</span><span style="color: #00702a">></span>
<span style="color: #00702a"><description</span> <span style="color: #354bb3">summary=</span><span style="color: #766510">"blah-blah"</span><span style="color: #00702a">></description></span>
<span style="color: #00702a"><arg</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"mode"</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"uint"</span> <span style="color: #354bb3">enum=</span><span style="color: #766510">"cursor_mode"</span> <span style="color: #354bb3">summary=</span><span style="color: #766510">"supported cursor mode"</span><span style="color: #00702a">/></span>
<span style="color: #00702a"></event></span></pre></div></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28882#inline-167049">View Inline</a><span style="color: #4b4d51; font-weight: bold;">screencast.xml:8</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96"> ]]></span><span style="color: #00702a"></copyright></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><interface</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"zkde_screencast_unstable_v1"</span> <span style="color: #354bb3">version=</span><span style="color: #766510">"1"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><description</span> <span style="color: #354bb3">summary=</span><span style="color: #766510">"Protocol for managing Pipewire feeds of the different displays and windows."</span><span style="color: #00702a">/></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Interfaces usually come without <tt style="background: #ebebeb; font-size: 13px;">unstable</tt> in the name.</p>
<p style="padding: 0; margin: 8px;">s/zkde_screencast_unstable_v1/zkde_screencast_v1/</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28882#inline-167047">View Inline</a><span style="color: #4b4d51; font-weight: bold;">screencast.xml:52-54</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><request</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"close"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><description</span> <span style="color: #354bb3">summary=</span><span style="color: #766510">"requests closing a pipewire buffer"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"></request></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">zkde_screencast_stream_unstable_v1 must have a destructor request.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28882">https://phabricator.kde.org/D28882</a></div></div><br /><div><strong>To: </strong>apol, KWin, jgrulich, davidedmundson, zzag<br /><strong>Cc: </strong>meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>