<table><tr><td style="">nhiga added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29223">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D29223#658229" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D29223#658229</a>, <a href="https://phabricator.kde.org/p/cgiboudeaux/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@cgiboudeaux</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I suppose you rename the file for a good reason. Are there different "official" languages for Taiwan?</p></div>
</blockquote>
<p>The new file name follows the same naming scheme used by the PRC (mainland China) holiday file, <tt style="background: #ebebeb; font-size: 13px;">holiday_cn_zh-cn</tt> (holiday_region_Language-Region). It is also less ambiguous because <tt style="background: #ebebeb; font-size: 13px;">zh</tt> alone does not indicate the character set being used (i.e. Simplified Chinese or Traditional Chinese).</p>
<p>Actually the holiday file for Hong Kong, <tt style="background: #ebebeb; font-size: 13px;">holiday_hk_zh-cn</tt>, should be renamed to <tt style="background: #ebebeb; font-size: 13px;">holiday_hk_zh-hk</tt> because <tt style="background: #ebebeb; font-size: 13px;">zh-cn</tt> means Simplified Chinese, but Hong Kong uses Traditional Chinese, but this will be another story.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R175 KHolidays</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29223">https://phabricator.kde.org/D29223</a></div></div><br /><div><strong>To: </strong>nhiga, winterz, cgiboudeaux, shrapnel<br /><strong>Cc: </strong>KDE PIM, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>