<table><tr><td style="">meven added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28909">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28909#inline-166667">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">kio_smb.h:96</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Excellent idea, but why wait for KF6?</p>
<p style="padding: 0; margin: 8px;">We could implement a subclass of SlaveBase, in KIO, let's call it SlaveBaseV2, which</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Reimplements all the virtual methods from SlaveBase, in a private section</li>
<li class="remarkup-list-item">Defines a new of virtual methods, called differently somehow</li>
<li class="remarkup-list-item">Implements the signal emission based on the return value of those new virtual methods.</li>
</ul>
<p style="padding: 0; margin: 8px;">This allows for incremental porting of the slaves, instead of a big KF6 breakage.<br />
And the V2 class can be developed in a single slave first, before having to freeze its API.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Sounds like a nice idea.</p>
<p style="padding: 0; margin: 8px;">File ioslave would be the best one to work on first IMO, since it is the one the most complete, used and tested, albeit one of the biggest probably.</p>
<p style="padding: 0; margin: 8px;">Let's make a task !</p>
<p style="padding: 0; margin: 8px;">But this diff does not need to wait for this.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R320 KIO Extras</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28909">https://phabricator.kde.org/D28909</a></div></div><br /><div><strong>To: </strong>sitter, dfaure<br /><strong>Cc: </strong>meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov<br /></div>