<table><tr><td style="">alex edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-pensfoggfs65ez2/">(Show Details)</a>
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29101">View Revision</a></tr></table><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>`<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">``</span>qWarning() << QProcess::execute("echo \"Hello there!\""); // Works<br />
qWarning() << QProcess::execute("echo",{"\"Hello there!\""}); // Works<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"><br />
qWarning() << QProcess::execute("echo \"Hello there!\"",{}); // Fails, returns -2`/<br />
<br />
As in https://phabricator.kde.org/R304:9322aaf990dd0500a81914d9f69183293cc08a58 explained <br />
QProcess::execute(QString) is deprecated, should KShell be used?</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">And should this be split up</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">qWarning() << QProcess::execute("echo \"Hello there!\"",{}); // Fails</span>, <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">because it is unrelated to the other change?</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">returns -2```</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29101">https://phabricator.kde.org/D29101</a></div></div><br /><div><strong>To: </strong>alex, KNewStuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>