<table><tr><td style="">davidedmundson requested changes to this revision.<br />davidedmundson added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28882">View Revision</a></tr></table><br /><div><div><p>In future, it might be faster to put up just the interface xml for review first.</p>
<hr class="remarkup-hr" />
<p>In terms of wayland protocols this is non-standard.</p>
<p>All clients get a list of available sources. On bind they get all all available sources via addSource. Additional sources are new events. <br />
That part's fine.</p>
<p>The part with nodeID is unusual. It's convention (though not technically the law) that globals broadcast the same thing to all bound resources.</p>
<p>ClientA requests create.<br />
All clients get a created event<br />
There's no way to tie a created or failed to the original request <br />
Client A and B can both connect to the same source, yet either can call close.</p>
<p>If we're doing a waland protocol I would have expected:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">ScreenCastInterface - global
event: source_added
event: done
request: get_stream (returns a ScreenStream object)
ScreenStream - resource
event: created
event: failed
event: closed (closed by external sources, clients should now release the stream resource)
request: release (closes the stream if applicable, is also of type destructor)</pre></div></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28882#inline-166391">View Inline</a><span style="color: #4b4d51; font-weight: bold;">screencast.xml:16</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"></enum></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><event</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"addSource"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><description</span> <span style="color: #354bb3">summary=</span><span style="color: #766510">"Notifies about a feed being created"</span><span style="color: #00702a">/></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Typically events are like signals, so would be called "source_added"</p>
<p style="padding: 0; margin: 8px;">Convention is also lower_snake_case</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28882#inline-166389">View Inline</a><span style="color: #4b4d51; font-weight: bold;">screencast.xml:31</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><description</span> <span style="color: #354bb3">summary=</span><span style="color: #766510">"Notifies about a source becoming unavailable"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><arg</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"sourceId"</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"uint"</span> <span style="color: #354bb3">summary=</span><span style="color: #766510">"the source identifier"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"></event></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this is racey with create.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28882">https://phabricator.kde.org/D28882</a></div></div><br /><div><strong>To: </strong>apol, KWin, jgrulich, davidedmundson<br /><strong>Cc: </strong>davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>