<table><tr><td style="">alex created this revision.<br />alex added reviewers: KNewStuff, meven, ngraham.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />alex requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29123">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>As described in the bug report the uninstallation failed, but the<br />
service was marked as removed. Now the service gets only marked as<br />
uninstalled if the script runs without an error. If there is an error<br />
the user gets a popup.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Set the exit code to 1 and try to install a dolphin plugin.<br />
You should get an error message.</p>
<p>Without modifying the exit code you should be able to install services.</p>
<p>The manual deletion can be tested by removing the installed service file. for example:<br />
rm ~/.local/share/kservices5/ServiceMenus/iso_mounter_unmounter.desktop<br />
Then the uninstaller will crash:<br />
"Failed to remove .desktop file ... No such file or directory" <br />
Then you delete the installed file manually:<br />
rm ~/.local/share/servicemenu-download/iso_mounter_unmounter.desktop<br />
And now you can click the uninstall button and it gets removed<br />
from the list of installed services.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br /><div><strong>BRANCH</strong><div><div>bugfix_install_uninstall_messages (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29123">https://phabricator.kde.org/D29123</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/core/CMakeLists.txt<br />
src/core/engine.cpp<br />
src/core/installation.cpp<br />
src/core/installation.h</div></div></div><br /><div><strong>To: </strong>alex, KNewStuff, meven, ngraham<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>