<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29065">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29065#inline-166008">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kfontchooser.h:90</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">ShowDifferences</span> <span style="color: #aa2211">=</span> <span style="color: #601200">4</span> <span style="color: #74777d">///< Display the font differences interfaces</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ShowDifferences</span> <span style="color: #aa2211">=</span> <span style="color: #601200">4<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span> <span style="color: #74777d">///< Display the font differences interfaces</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">NoFixedOnlyToggle</span> <span style="color: #aa2211">=</span> <span style="color: #601200">5</span> <span style="color: #74777d">///< Show a checkbox to toggle showing only fixed fonts</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">1/2/4 looked like powers of 2, i.e. a flag set.</p>
<p style="padding: 0; margin: 8px;">Using 5 here gives is the same value as FixedFontsOnly | ShowDifferences.</p>
<p style="padding: 0; margin: 8px;">On the other hand it makes sense FixedFontsOnly would automatically hide the checkbox, no? If the app says "fixed fonts only", the user has no choice in the matter.</p>
<p style="padding: 0; margin: 8px;">I'm also confused by the name "No[...]Toggle" and the docu saying this will show a checkbox. Something's off by "not" ;)<br />
Sounds wrong?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R236 KWidgetsAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29065">https://phabricator.kde.org/D29065</a></div></div><br /><div><strong>To: </strong>ahmadsamir, Frameworks, dfaure, cfeck, bport<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>