<table><tr><td style="">ognarb accepted this revision.<br />ognarb added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29084">View Revision</a></tr></table><br /><div><div><p>Good idea to improve the default HTML file.</p>
<p>Improvement ideas:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Don't include <tt style="background: #ebebeb; font-size: 13px;"><style></syle></tt>, it's not recommanded to inclde <style> elements but instead to link to a css file.</li>
</ul>
<ul class="remarkup-list">
<li class="remarkup-list-item">Maybe you could also include the usual HTML semantic elements:</li>
</ul>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><body>
<header>
<nav></nav>
</header>
<section></section>
<footer></footer>
</body></pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>BRANCH</strong><div><div>html-file-template (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29084">https://phabricator.kde.org/D29084</a></div></div><br /><div><strong>To: </strong>gszymaszek, Frameworks, dfaure, ognarb<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>