<table><tr><td style="">poboiko marked 3 inline comments as done.<br />poboiko added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28854">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D28854#649189" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D28854#649189</a>, <a href="https://phabricator.kde.org/p/abstractdevelop/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@abstractdevelop</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Hey, thanks for this <a href="https://phabricator.kde.org/p/poboiko/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@poboiko</a> I used to have to implement this myself, so this will be very useful in my app, O20.Word. ;)</p></div>
</blockquote>
<p>Sure, you're welcome! I like doing useful stuff :)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28854#inline-164569">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">krichtextedit.cpp:346</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">If boundedLevel is 6, the size adjustement will be -1?<br />
Does this mean a heading that's smaller than normal text?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Yes, that's true. I agree it's a bit confusing, but that's the case with HTML too, which I had in mind (see screenshot, it's Chrome)<br />
<a href="https://phabricator.kde.org/F8241667" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8241667: scr1.png</a></p>
<p style="padding: 0; margin: 8px;">For markdown, it seems like there are only 5 levels, 5th having the same size as normal text (6th level gets ignored, that's Okular)<br />
<a href="https://phabricator.kde.org/F8241670" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8241670: scr2.png</a></p>
<p style="padding: 0; margin: 8px;">I guess we probably can follow the Markdown way and bound it with 5, just to avoid confusion.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28854#inline-164633">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">krichtextedit.cpp:375</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">This seems to duplicate what happened with selectCursor already. Why are two cursors necessary to change the style of one paragraph?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I used <tt style="background: #ebebeb; font-size: 13px;">selectCursor</tt> to select a line (block) under cursor and then change the style of the selection with <tt style="background: #ebebeb; font-size: 13px;">mergeCharFormat</tt> .</p>
<p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">cursor</tt> is for actual users cursor, which also has to change the style, so newly typed text will have the same style and heading level too (I use <tt style="background: #ebebeb; font-size: 13px;">mergeBlockCharFormat</tt> for that reason - if I use <tt style="background: #ebebeb; font-size: 13px;">mergeCharFormat</tt> here, the cursor will remain big after I press <tt style="background: #ebebeb; font-size: 13px;">Enter</tt> after a title. However, it will change its size to the smaller one immediately after I start typing). But I don't want to mess with users selection, that's why I'm keeping both.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R310 KTextWidgets</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28854">https://phabricator.kde.org/D28854</a></div></div><br /><div><strong>To: </strong>poboiko, Frameworks, mlaurent, ahmadsamir, dfaure<br /><strong>Cc: </strong>abstractdevelop, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>