<table><tr><td style="">fvogt requested changes to this revision.<br />fvogt added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28856">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28856#inline-164586">View Inline</a><span style="color: #4b4d51; font-weight: bold;">globalshortcutsregistry.cpp:274</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">auto</span> <span class="n">disabledComponents</span> <span style="color: #aa2211">=</span> <span class="n">KConfigGroup</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">_config</span><span class="p">,</span> <span style="color: #766510">"disabledComponents"</span><span class="p">).</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"disabled"</span><span class="p">,</span> <span class="n">QStringList</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span style="color: #a0a000">groupName</span> <span class="p">:</span> <span class="n">groupList</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">disabledComponents</tt> is the group name, right? It would also be part of <tt style="background: #ebebeb; font-size: 13px;">groupList</tt>, so it would try to load it as shortcut...</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28856#inline-164585">View Inline</a><span style="color: #4b4d51; font-weight: bold;">globalshortcutsregistry.cpp:333</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span style="color: #a0a000">desktopFile</span> <span class="p">:</span> <span class="n">lstDesktopFiles</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">_components</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">desktopFile</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">_components</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">desktopFile</span><span class="p">)<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span class="n"><span class="bright">disabledComponents</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">contains</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">desktopFile</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">continue</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is <tt style="background: #ebebeb; font-size: 13px;">desktopFile</tt> the equivalent to <tt style="background: #ebebeb; font-size: 13px;">component->uniqueName()</tt>? I would assume no, so this check might need to be moved after the <tt style="background: #ebebeb; font-size: 13px;">KServiceActionComponent</tt> construction</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R268 KGlobalAccel</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28856">https://phabricator.kde.org/D28856</a></div></div><br /><div><strong>To: </strong>davidre, davidedmundson, fvogt, meven<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>