<table><tr><td style="">ahmadsamir added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28855">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28855#inline-164594">View Inline</a><span style="color: #4b4d51; font-weight: bold;">netpref.cpp:87</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">cb_globalMarkPartial</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QAbstractButton</span><span style="color: #aa2211">::</span><span class="n">toggled</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">partialWidget</span><span class="p">,</span> <span class="p">[</span><span class="n">partialWidget</span><span class="p">](</span><span style="color: #aa4000">bool</span> <span class="n">checked</span><span class="p">)</span> <span class="p">{</span> <span class="n">partialWidget</span><span style="color: #aa2211">-></span><span class="n">setEnabled</span><span class="p">(</span><span class="n">checked</span><span class="p">);</span> <span class="p">});</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">globalLayout</span><span style="color: #aa2211">-></span><span class="n">addWidget</span><span class="p">(</span><span class="n">partialWidget</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why not "&QWidget::setEnabled" instead of the lambda?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28855#inline-164597">View Inline</a><span style="color: #4b4d51; font-weight: bold;">netpref.cpp:89</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">globalLayout</span><span style="color: #aa2211">-></span><span class="n">addWidget</span><span class="p">(</span><span class="n">partialWidget</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">auto</span> <span class="n">partialLayout</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QFormLayout</span><span class="p">(</span><span class="n">gb_Global</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">partialLayout</span><span style="color: #aa2211">-></span><span class="n">setContentsMargins</span><span class="p">(</span><span style="color: #601200">20</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">);</span> <span style="color: #74777d">// indent below mark partial</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This triggers this warning:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">QLayout: Attempting to add QLayout "" to QGroupBox "", which already has a layout</pre></div>
<p style="padding: 0; margin: 8px;">I've just found out that QWidget::setLayout(QLayout *layout) will take ownership of "layout":<br />
<a href="https://doc.qt.io/qt-5/qwidget.html#setLayout" class="remarkup-link" target="_blank" rel="noreferrer">https://doc.qt.io/qt-5/qwidget.html#setLayout</a><br />
so I guess there is no need to set a parent for partialLayout when instantiating it.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28855#inline-164598">View Inline</a><span style="color: #4b4d51; font-weight: bold;">netpref.cpp:92</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">partialWidget</span><span style="color: #aa2211">-></span><span class="n">setLayout</span><span class="p">(</span><span class="n">partialLayout</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">sb_globalMinimumKeepSize</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KPluralHandlingSpinBox</span><span class="p">(</span> <span style="color: #aa4000">this</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">sb_globalMinimumKeepSize</span><span style="color: #aa2211">-></span><span class="n">setSuffix</span><span class="p">(</span> <span class="n">ki18np</span><span class="p">(</span> <span style="color: #766510">" byte"</span><span class="p">,</span> <span style="color: #766510">" bytes"</span> <span class="p">)</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Coding style, no space after ( or before ), IIUC.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28855#inline-164599">View Inline</a><span style="color: #4b4d51; font-weight: bold;">netpref.cpp:93</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">sb_globalMinimumKeepSize</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KPluralHandlingSpinBox</span><span class="p">(</span> <span style="color: #aa4000">this</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">sb_globalMinimumKeepSize</span><span style="color: #aa2211">-></span><span class="n">setSuffix</span><span class="p">(</span> <span class="n">ki18np</span><span class="p">(</span> <span style="color: #766510">" byte"</span><span class="p">,</span> <span style="color: #766510">" bytes"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">sb_globalMinimumKeepSize</span><span class="p">,</span> <span class="n">QOverload</span><span style="color: #aa2211"><</span><span style="color: #aa4000">int</span><span style="color: #aa2211">>::</span><span class="n">of</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">QSpinBox</span><span style="color: #aa2211">::</span><span class="n">valueChanged</span><span class="p">),</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Same.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28855#inline-164605">View Inline</a><span style="color: #4b4d51; font-weight: bold;">netpref.cpp:96</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">KIOPreferences</span><span style="color: #aa2211">::</span><span class="n">configChanged</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">partialLayout</span><span style="color: #aa2211">-></span><span class="n">addRow</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span> <span style="color: #766510">"@label:spinbox"</span><span class="p">,</span> <span style="color: #766510">"Minimum size required to keep on cancel:"</span> <span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">sb_globalMinimumKeepSize</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">"If cancelled, automatically delete partially uploaded files smaller than"</p>
<p style="padding: 0; margin: 8px;">And same coding style as before.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28855">https://phabricator.kde.org/D28855</a></div></div><br /><div><strong>To: </strong>sitter, ngraham, dfaure<br /><strong>Cc: </strong>ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>