<table><tr><td style="">kmaterka updated this revision to Diff 80148.<br />kmaterka marked an inline comment as done.<br />kmaterka added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28470">View Revision</a></tr></table><br /><div><div><p>Do not inherit from QObject</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D28470?vs=79283&id=80148">https://phabricator.kde.org/D28470?vs=79283&id=80148</a></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28470">https://phabricator.kde.org/D28470</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/declarativeimports/core/iconitem.cpp<br />
src/declarativeimports/core/iconitem.h</div></div></div><br /><div><strong>To: </strong>kmaterka, Plasma, broulik, apol, davidedmundson<br /><strong>Cc: </strong>mart, davidre, cblack, kde-frameworks-devel, Plasma, LeGast00n, michaelh, ngraham, bruns<br /></div>