<table><tr><td style="">sandsmark added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25267">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D25267#647148" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D25267#647148</a>, <a href="https://phabricator.kde.org/p/aacid/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@aacid</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Seems like the windows build is broken :/</p>

<p><a href="https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.14/16/console" class="remarkup-link" target="_blank" rel="noreferrer">https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.14/16/console</a></p></div>
</blockquote>

<p>Seems like I forgot to use the custom rand_r (to avoid exactly that + get the same noise function as windows) a couple of places.</p>

<p>Should just be to replace <tt style="background: #ebebeb; font-size: 13px;">rand_r</tt> with <tt style="background: #ebebeb; font-size: 13px;">RandomTable::rand_r</tt> where it is missing, okay if I just do that in master?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R287 KImageFormats</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25267">https://phabricator.kde.org/D25267</a></div></div><br /><div><strong>To: </strong>sandsmark, aacid, cfeck, apol, vkrause<br /><strong>Cc: </strong>ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns<br /></div>