<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28770">View Revision</a></tr></table><br /><div><div><p>I don't fully understand the need for a thread here.<br />
It merely blocks because the API is synchronous and thus we create a nested eventloop.<br />
I don't think the writing and parsing of the cache file is a real bottleneck here.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28770#inline-164006">View Inline</a><span style="color: #4b4d51; font-weight: bold;">currency.cpp:57</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QNetworkInterface</span> <span style="color: #aa2211">&</span><span style="color: #a0a000">net</span> <span class="p">:</span> <span class="n">QNetworkInterface</span><span style="color: #aa2211">::</span><span class="n">allInterfaces</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">net</span><span class="p">.</span><span class="n">flags</span><span class="p">().</span><span class="n">testFlag</span><span class="p">(</span><span class="n">QNetworkInterface</span><span style="color: #aa2211">::</span><span class="n">IsUp</span><span class="p">))</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can probably just use <tt style="background: #ebebeb; font-size: 13px;">QNetworkConfigurationManager::isOnline()</tt>?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28770#inline-164007">View Inline</a><span style="color: #4b4d51; font-weight: bold;">currency.cpp:124</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">static</span> <span class="n">QNetworkAccessManager</span> <span class="n">m_netAccessManager</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use prefix <tt style="background: #ebebeb; font-size: 13px;">s_</tt> since it's static</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28770#inline-164008">View Inline</a><span style="color: #4b4d51; font-weight: bold;">currency.cpp:154</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">m_reply</span> <span style="color: #aa2211">=</span> <span class="n">m_netAccessManager</span><span class="p">.</span><span class="n">get</span><span class="p">(</span><span class="n">QNetworkRequest</span><span class="p">(</span><span class="n">QUrl</span><span class="p">(</span><span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">fromLatin1</span><span class="p">(</span><span class="n">URL</span><span class="p">))));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">connect</span><span class="p">(</span><span class="n">m_reply</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QNetworkReply</span><span style="color: #aa2211">::</span><span class="n">finished</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">CurrencyCacheUpdater</span><span style="color: #aa2211">::</span><span class="n">onReplyFinished</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Whenever you do networking in KDE, ensure it follows redirects:<br />
<tt style="background: #ebebeb; font-size: 13px;">setRedirectPolicy(QNetworkRequest::NoLessSafeRedirectPolicy)</tt> I guess</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R292 KUnitConversion</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28770">https://phabricator.kde.org/D28770</a></div></div><br /><div><strong>To: </strong>sandsmark, ngraham, Frameworks, broulik<br /><strong>Cc: </strong>broulik, ngraham, kde-frameworks-devel, Frameworks, LeGast00n, cblack, michaelh, bruns<br /></div>