<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24773">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24773#inline-164057">View Inline</a><span style="color: #4b4d51; font-weight: bold;">trashsizecache.cpp:131</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">qint64</span> <span class="n">max_mtime</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">checMaxTime</span> <span style="color: #aa2211">=</span> <span class="p">[</span><span class="n">max_mtime</span><span class="p">]</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">qint64</span> <span class="n">lastModTime</span><span class="p">)</span> <span style="color: #aa2211">-></span> <span class="n">qint64</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">return</span> <span class="n">lastModTime</span> <span style="color: #aa2211">></span> <span class="n">max_mtime</span> <span style="color: #aa2211">?</span> <span style="color: #a0a000">lastModTime</span> <span class="p">:</span> <span class="n">max_mtime</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Typo: checkMaxTime with a 'k'?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24773#inline-164061">View Inline</a><span style="color: #4b4d51; font-weight: bold;">trashsizecache.cpp:131</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">qint64</span> <span class="n">max_mtime</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">checMaxTime</span> <span style="color: #aa2211">=</span> <span class="p">[</span><span class="n">max_mtime</span><span class="p">]</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">qint64</span> <span class="n">lastModTime</span><span class="p">)</span> <span style="color: #aa2211">-></span> <span class="n">qint64</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">return</span> <span class="n">lastModTime</span> <span style="color: #aa2211">></span> <span class="n">max_mtime</span> <span style="color: #aa2211">?</span> <span style="color: #a0a000">lastModTime</span> <span class="p">:</span> <span class="n">max_mtime</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Interesting. One benefit of lambdas is that they can work on local variable; I would have captured max_mtime by reference and modified it inside the lambda.<br />
Written this way (which I guess more "pure functional programming" because no side effects), it could be a static helper function ;)</p>

<p style="padding: 0; margin: 8px;">Wait, this doesn't work, does it? It makes a copy of mtime right now, while it's still 0.</p>

<p style="padding: 0; margin: 8px;">I'm pretty sure you want to capture by [&] instead<br />
(and then, unless you insist on pure functions, I'd suggest just modifying it here, and returning void). It removes the "max_mtime = " duplication ;)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24773">https://phabricator.kde.org/D24773</a></div></div><br /><div><strong>To: </strong>meven, Frameworks, ngraham, elvisangelaccio, dfaure<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>