<table><tr><td style="">ochurlaud added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28712">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D28712#645095" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D28712#645095</a>, <a href="https://phabricator.kde.org/p/ognarb/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ognarb</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Not tested yet but I like the style :) Though to be more consistent with the style used in other KDE websites, I would change the background color to #fff and use #f8f9fa for the sidebar.</p>
<p>I also saw some alignment issues with the method args:</p>
<p><a href="https://phabricator.kde.org/F8227657" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8227657: image.png</a></p>
<p>I will give a more in-depth review tomorrow.</p></div>
</blockquote>
<p>The issues already exist in the current design. I would do a second change request for fixing those issues (there are more if you browse a little in complex methods) and already push this cosmetic only patch.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R264 KApiDox</div></div></div><br /><div><strong>BRANCH</strong><div><div>cblack/aether (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28712">https://phabricator.kde.org/D28712</a></div></div><br /><div><strong>To: </strong>cblack, VDG, ognarb, ochurlaud<br /><strong>Cc: </strong>ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, GB_2, michaelh, bruns, skadinna<br /></div>