<table><tr><td style="">apol accepted this revision.<br />apol added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28599">View Revision</a></tr></table><br /><div><div><p>LGTM</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28599#inline-162885">View Inline</a><span style="color: #4b4d51; font-weight: bold;">configview.cpp:137</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">engine</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">rootContext</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">setContextProperty</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"plasmoid"</span><span class="p">),</span> <span class="n">applet</span><span class="p">.</span><span class="n">data</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">property</span><span class="p">(</span><span style="color: #766510">"_plasma_graphicObject"</span><span class="p">).</span><span class="n">value</span><span style="color: #aa2211"><</span><span class="n">QObject</span> <span style="color: #aa2211">*></span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">engine</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">rootContext</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">setContextProperty</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"configDialog"</span><span class="p">),</span> <span class="n">q</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It could make sense to use the opportunity to change to QQmlContext::setContextProperties.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28599">https://phabricator.kde.org/D28599</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma, apol<br /><strong>Cc: </strong>apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>