<table><tr><td style="">ahmadsamir updated this revision to Diff 79373.<br />ahmadsamir retitled this revision from "Port from QRegExp to QRegularExpression" to "[KTextWidgets] Port from QRegExp to QRegularExpression".<br />ahmadsamir edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-mj4bzyaidps2qbf/">(Show Details)</a><br />ahmadsamir edited the test plan for this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-dynqtb4sokmkxhi/">(Show Details)</a><br />ahmadsamir added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27097">View Revision</a></tr></table><br /><div><div><p>Update</p></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">Port QRegExp::setMinimal() by making the regex pattern non-greedy,</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">Deprecate the KFind::find() and KReplace::replace() methods that take a<br />
QRegExp;</span> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">where</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">Regular Expression matches will be handled internally if the</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">possible</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">KFind::RegularExpression flag is set</span>.<br />
<br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">Deprecate the KFind::find() and KReplace::replace() methods that take a</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">Port QRegExp::setMinimal() by making the regex pattern non-greedy, where</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">QRegExp</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">possible</span>.</div></div></div><br /><div><strong>CHANGES TO TEST PLAN</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>- <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">ktexteditest still works. N.B. backwards search still works, but invoking<br />
it a second time (via Shift+F3) doesn't work i.e. it's stuck at the<br />
same match, but this happens on master too</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">a quick test of searching and replacing in ktexteditest still works</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R310 KTextWidgets</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D27097?vs=74871&id=79373">https://phabricator.kde.org/D27097?vs=74871&id=79373</a></div></div><br /><div><strong>BRANCH</strong><div><div>l-qregularexpression (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27097">https://phabricator.kde.org/D27097</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/kfindtest.cpp<br />
autotests/kfindtest.h<br />
autotests/krichtextedittest.cpp<br />
src/CMakeLists.txt<br />
src/findreplace/kfind.cpp<br />
src/findreplace/kfind.h<br />
src/findreplace/kfinddialog.cpp<br />
src/findreplace/kreplace.cpp<br />
src/findreplace/kreplace.h<br />
src/widgets/krichtextedit.cpp</div></div></div><br /><div><strong>To: </strong>ahmadsamir, Frameworks, mlaurent, dfaure<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>