<table><tr><td style="">kmaterka added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28470">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D28470#641230" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D28470#641230</a>, <a href="https://phabricator.kde.org/p/davidre/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@davidre</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D28470#640468" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D28470#640468</a>, <a href="https://phabricator.kde.org/p/cblack/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@cblack</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Splitting into multiple classes seems like a good idea, but "strategy"? Seems like an odd choice of name to me.</p></div>
</blockquote>
<p>I had assumed it's because of <a href="https://en.m.wikipedia.org/wiki/Strategy_pattern" class="remarkup-link" target="_blank" rel="noreferrer">https://en.m.wikipedia.org/wiki/Strategy_pattern</a></p></div>
</blockquote>
<p>Yeah, I totally agree, it is really confusing now. I'm bad at creating class names :)<br />
I wanted to extract source handling (logic, internal state) to separate classes. "Handler" is overused, maybe something like this:<br />
IconItemSource (or AbstractIconItemSource, or AbstractSource), then:<br />
QImageSource (or QImageIconItemSource)<br />
QIconSource (or QIconIconItemSource)<br />
SvgSource (or SvgIconItemSource)<br />
What do you think?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28470">https://phabricator.kde.org/D28470</a></div></div><br /><div><strong>To: </strong>kmaterka, Plasma, broulik, apol, davidedmundson<br /><strong>Cc: </strong>davidre, cblack, kde-frameworks-devel, Plasma, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>