<table><tr><td style="">pino added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28532">View Revision</a></tr></table><br /><div><div><p>Please fix the i18n() calls, as the values of placeholders are passed as parameter to it instead of using .arg():</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="c++" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"foo %1"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">foo</span><span class="p">)</span>  <span style="color: #74777d">// WRONG</span>
<span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"foo %1"</span><span class="p">,</span> <span class="n">foo</span><span class="p">)</span>  <span style="color: #74777d">// correct</span></pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28532">https://phabricator.kde.org/D28532</a></div></div><br /><div><strong>To: </strong>leinir, KNewStuff, Plasma, ngraham, Frameworks<br /><strong>Cc: </strong>pino, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>