<table><tr><td style="">meven added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28478">View Revision</a></tr></table><br /><div><div><p>Just a few nitpicks in test and this is good IMHO</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28478#inline-162289">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jobtest.cpp:1516</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVERIFY2</span><span class="p">(</span><span class="n">job</span><span style="color: #aa2211">-></span><span class="n">exec</span><span class="p">(),</span> <span class="n">qPrintable</span><span class="p">(</span><span class="n">job</span><span style="color: #aa2211">-></span><span class="n">errorString</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// TODO set setSide</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntry</span> <span style="color: #aa2211">&</span><span class="n">entry</span> <span style="color: #aa2211">=</span> <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">statResult</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can remove</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28478#inline-162290">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jobtest.cpp:1530</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#if 1 </span><span style="color: #74777d">// should be #ifdef HAVE_STATX</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVERIFY</span><span class="p">(</span><span class="n">entry</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntry</span><span style="color: #aa2211">::</span><span class="n">UDS_CREATION_TIME</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">entry</span><span class="p">.</span><span class="n">count</span><span class="p">(),</span> <span style="color: #601200">11</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If you want to avoid doing this you can remove fields asked from statDetails <tt style="background: #ebebeb; font-size: 13px;">KIO::StatBasic | KIO::StatUser | KIO::StatInode</tt> for instance.<br />
And have a more focused test.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28478#inline-162288">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jobtest.cpp:1566</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">otherDevice</span> <span style="color: #aa2211">=</span> <span class="n">otherEntry</span><span class="p">.</span><span class="n">numberValue</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">UDSEntry</span><span style="color: #aa2211">::</span><span class="n">UDS_DEVICE_ID</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">qDebug</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"device ID:"</span> <span style="color: #aa2211"><<</span> <span class="n">device</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"; otherDevice ID:"</span> <span style="color: #aa2211"><<</span> <span class="n">otherDevice</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QVERIFY</span><span class="p">(</span><span class="n">device</span> <span style="color: #aa2211">!=</span> <span class="n">otherDevice</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You can remove this now ;)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28478#inline-162292">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jobtest.cpp:1568</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QVERIFY</span><span class="p">(</span><span class="n">device</span> <span style="color: #aa2211">!=</span> <span class="n">otherDevice</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You can have an else with just <tt style="background: #ebebeb; font-size: 13px;"> QCOMPARE(device, otherDevice);</tt> and move most of the  code inside of <tt style="background: #ebebeb; font-size: 13px;">if (!otherTmpDirIsOnSamePartition())</tt> outside of the if branch.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28478">https://phabricator.kde.org/D28478</a></div></div><br /><div><strong>To: </strong>ahmadsamir, Frameworks, dfaure, meven, bruns<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>